support g722-16khz-64kbps audio output format #815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| 2, | ||
| 16, | ||
| speechSynthesisOutputFormatString, | ||
| speechSynthesisOutputFormatString, |
There was a problem hiding this comment.
are you sure this second line is correct.
looks like cut and past error, when compared to some of the other formats that have an actual literal format sting in the second position.
e.g. should it have one of these new values.
[SpeechSynthesisOutputFormat.AmrWb16000Hz]: "amr-wb-16000hz",
[SpeechSynthesisOutputFormat.G72216Khz64Kbps]: "g722-16khz-64kbps",
There was a problem hiding this comment.
Thanks for noticing this.
The two formats (customer request to sdk and sdk requests to service) are different if the format has header. E.g., we will replace riff to raw to get the streaming output.
For the new added formats in this PR, they have no header so the two lines should be same
| 2, | ||
| 16, | ||
| speechSynthesisOutputFormatString, | ||
| speechSynthesisOutputFormatString, |
There was a problem hiding this comment.
same question/comment here
BrianMouncer
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.